-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpv-plugin/open-in-mpv-bin: new package, add 2.3.0 #252
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Vitaly Zdanevich <[email protected]>
@pastalian please review |
I don't really have any comments on this ebuild. You should get approval from guru-trusted, which I'm not a part of. |
Could we have a non -bin ebuild? It seems doable |
Ok, but it is also good to have |
About "backups", that's why we usually left at least one older version, so if a new version is broken one can switch to the older one. Only when a package is arguably difficult to build from source (eg: electron programs) or there is some other justification (eg: very big build times as with libreoffice) it's reasonable to have a -bin version. I don't find any good reasons to have a binary ebuild for this, so I am not merging it. |
But why Gentoo added binary mirror for all packages? https://www.gentoo.org/news/2023/12/29/Gentoo-binary.html
|
As you quote it, for slow hardware and programs that take a lot to compile. Because adding a duplicated Another important point is that portage will detect if the USE flags are different or there is some change between the binhost and your computer in which case it will fall back to compile the program instead of graving the binary. This keeps the coherency of your system, which is much harder to do when one installs pre-compiled binaries without any kind of checking of how those binaries were built. If you want binaries for arbitrary packages, create your own binhost with whatever is convenient for you. See https://wiki.gentoo.org/wiki/Binary_package_guide |
ok, asked upstream about vendoring Baldomo/open-in-mpv#37 |
As it says in the wiki, you can also upload the tarball to Github and create a tag for each release. |
@vitaly-zdanevich the procedure to package the dependencies is documented here: https://wiki.gentoo.org/wiki/Writing_go_Ebuilds#Packaging_the_dependencies It is the packager's job to package dependencies for Gentoo, not upstream. If you will not do it, then please close this PR. |
Replacement for 17ce941#diff-de89c63c4a2f61950d8337a8c2be1939190e122bba9dd4cad2c5a53a7f2814afL9